[Kst] [kst] [Bug 342642] New: Kst 2.0.8 fails to compile on Fedora Rawhide Arm

[Orion Poplawski]

https://bugs.kde.org/show_bug.cgi?id=342642

Bug ID: 342642
Summary: Kst 2.0.8 fails to compile on Fedora Rawhide Arm
Product: kst
Version: 2.0.8
Platform: Other
OS: Linux
Status: UNCONFIRMED
Severity: major
Priority: NOR
Component: general
Assignee: ***@kde.org
Reporter: ***@cora.nwra.com

Updating kst in Fedora to 2.0.8, fails to compile on arm:

http://koji.fedoraproject.org/koji/getfile?taskID=8554368&name=build.log

/builddir/build/BUILD/Kst-2.0.8/src/libkst/vector.cpp:598:42: error: no
matching function for call to 'qMax(double&, qreal)'
_minPos=qMax(_minPos,qreal(0.0));
/builddir/build/BUILD/Kst-2.0.8/src/libkst/vector.cpp:602:45: error: no
matching function for call to 'qMax(double&, qreal)'
_minPos=qMin(qMax(_v[i],qreal(0.0)),_minPos);
/builddir/build/BUILD/Kst-2.0.8/src/libkst/vector.cpp:629:42: error: no
matching function for call to 'qMax(double&, qreal)'
_minPos=qMax(_minPos,qreal(0.0));
/builddir/build/BUILD/Kst-2.0.8/src/libkst/vector.cpp:633:45: error: no
matching function for call to 'qMax(double&, qreal)'
_minPos=qMin(qMax(_v[i],qreal(0.0)),_minPos);


Reproducible: Always




I believe similar issues with qreal have been addressed before.

[n***@astro.utoronto.ca]

https://bugs.kde.org/show_bug.cgi?id=342642

--- Comment #1 from ***@astro.utoronto.ca ---
Git commit 16d4aea302e9f9eeca86e3ad72f448b8303d31b5 by Barth Netterfield.
Committed on 11/01/2015 at 05:19.
Pushed by netterfield into branch 'master'.

Fix some qreal issues.

floating point values which count pixels or screen locations
can and should be qreal.

floating point values which are
involved with computational manipulation of the data
should be double, even though this is slower in ARM.

They shouldn't mix if it can be helped.

M +1 -1 src/libkst/editablevector.cpp
M +4 -4 src/libkst/vector.cpp
M +1 -1 src/libkstmath/curve.cpp
M +1 -1 src/plugins/dataobject/activitylevel/activitylevel.cpp

http://commits.kde.org/kst-plot/16d4aea302e9f9eeca86e3ad72f448b8303d31b5

[Orion Poplawski]

https://bugs.kde.org/show_bug.cgi?id=342642

--- Comment #2 from Orion Poplawski <***@cora.nwra.com> ---
Thanks, but I still get errors with:
/builddir/build/BUILD/Kst-2.0.8/src/libkst/vector.cpp:598:42: error: no
matching function for call to 'qMax(double&, qreal)'
_minPos=qMax(_minPos,qreal(0.0));
/builddir/build/BUILD/Kst-2.0.8/src/libkst/vector.cpp:602:45: error: no
matching function for call to 'qMax(double&, qreal)'
_minPos=qMin(qMax(_v[i],qreal(0.0)),_minPos);

[Orion Poplawski]

https://bugs.kde.org/show_bug.cgi?id=342642

--- Comment #3 from Orion Poplawski <***@cora.nwra.com> ---
And after those:
/builddir/build/BUILD/Kst-2.0.8/src/libkstmath/curve.cpp:687:83: error: no
matching function for call to 'qMax(qreal, double)'
return qMax(qreal(1.01), PointSize * ((w.width() + w.height()) * (1.0 /
4000.0)));

[n***@astro.utoronto.ca]

https://bugs.kde.org/show_bug.cgi?id=342642

***@astro.utoronto.ca changed:

What |Removed |Added
----------------------------------------------------------------------------
CC| |***@astro.utoronto.
| |ca

--- Comment #4 from ***@astro.utoronto.ca ---
Both of those were changed in git (origin/master (not 2.0.8, which has already
been released)).

Let me now if the changes work there.

[Rex Dieter]

https://bugs.kde.org/show_bug.cgi?id=342642

Rex Dieter <***@math.unl.edu> changed:

What |Removed |Added
----------------------------------------------------------------------------
CC| |***@math.unl.edu

[Orion Poplawski]

https://bugs.kde.org/show_bug.cgi?id=342642

--- Comment #5 from Orion Poplawski <***@cora.nwra.com> ---
Hmm, I seemed to have missed the vector changes somehow, but I think you are
missing:

diff --git a/src/libkstmath/curve.cpp b/src/libkstmath/curve.cpp
index 7e8c4bb..79182e6 100644
--- a/src/libkstmath/curve.cpp
+++ b/src/libkstmath/curve.cpp
@@ -684,7 +684,7 @@ RelationPtr Curve::makeDuplicate() const {
// and not just pulled out of the air by what looks ~good.
// They are currently "about right" for printing to US Letter.
double Curve::pointDim(QRectF w) const {
- return qMax(qreal(1.01), PointSize * ((w.width() + w.height()) * (1.0 /
4000.0)));
+ return qMax(double(1.01), PointSize * ((w.width() + w.height()) * (1.0 /
4000.0)));
}

double Curve::lineDim(const QRectF &R, double linewidth) {

[n***@astro.utoronto.ca]

https://bugs.kde.org/show_bug.cgi?id=342642

--- Comment #6 from ***@astro.utoronto.ca ---
Git commit 1365ccf2fd2da59025be623b97b7207f95ba8884 by Barth Netterfield.
Committed on 29/01/2015 at 16:18.
Pushed by netterfield into branch 'master'.

Fix another qreal/double issue

M +1 -1 src/libkstmath/curve.cpp

http://commits.kde.org/kst-plot/1365ccf2fd2da59025be623b97b7207f95ba8884

[via KDE Bugzilla]

https://bugs.kde.org/show_bug.cgi?id=342642

--- Comment #7 from ***@astro.utoronto.ca ---
Can anyone confirm whether this is still breaking?

[Rex Dieter via KDE Bugzilla]

https://bugs.kde.org/show_bug.cgi?id=342642

Rex Dieter <***@math.unl.edu> changed:

What |Removed |Added
----------------------------------------------------------------------------
Resolution|--- |FIXED
Status|UNCONFIRMED |RESOLVED

--- Comment #8 from Rex Dieter <***@math.unl.edu> ---
Looks good now,
http://koji.fedoraproject.org/koji/buildinfo?buildID=741522